Skip to content

Conversation

meeh0w
Copy link
Member

@meeh0w meeh0w commented Sep 1, 2025

Description

Adds warnings when simulation fails (isSimulationSuccessful: false) or we don't know if it succeded (isSimulationSuccessful: undefined).

Changes

Testing

  • Easiest by updating the code or blocking /scan endpoint in the devtools
image image

Screenshots:

TX.Warning.-.simulation.failed.mov
TX.Warning.-.no.balance.change.mov

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@meeh0w meeh0w mentioned this pull request Sep 1, 2025
2 tasks
@meeh0w meeh0w merged commit fb67b6d into feat/ng-tx-warnings Sep 5, 2025
3 checks passed
@meeh0w meeh0w deleted the feat/ng-tx-simulation-fail-warnings branch September 5, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants