-
Notifications
You must be signed in to change notification settings - Fork 268
use avago db factory to create new databases #1567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…labs/subnet-evm into ceyonur/use-avagodb-factory
StephenButtolph
approved these changes
May 12, 2025
Signed-off-by: Ceyhun Onur <[email protected]>
qdm12
approved these changes
May 15, 2025
Signed-off-by: Ceyhun Onur <[email protected]>
Signed-off-by: Ceyhun Onur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Changes in ava-labs/avalanchego#3899 lets us to use AvalancheGo database factory to create standalone dbs.
How this works
This pull request includes several updates to dependencies, refactoring of database-related code, and cleanup of unused or outdated components. The changes streamline database handling, improve maintainability, and update dependencies for compatibility.
github.com/ava-labs/avalanchego
to branch at Move database creation to database factory package avalanchego#3899plugin/evm/database/database.go
file, including theNewStandaloneDatabase
andNewPebbleDB
functions, and replaced them with a new implementation inplugin/evm/vm_database.go
.WrapDatabase
withwrapDatabase
and moved the implementation fromplugin/evm/database/wrapped_database.go
toplugin/evm/wrapped_database.go
.How this was tested
Existing tests should cover this
Need to be documented?
No
Need to update RELEASES.md?
No