Embed abis #382
Closed
Embed abis #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bnet-evm into trustless-precompile-configs
Co-authored-by: aaronbuchwald <[email protected]>
Co-authored-by: aaronbuchwald <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]>
…bnet-evm into trustless-precompile-configs
Co-authored-by: Darioush Jalali <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]>
…bnet-evm into trustless-precompile-configs
Co-authored-by: aaronbuchwald <[email protected]>
Co-authored-by: aaronbuchwald <[email protected]>
Co-authored-by: aaronbuchwald <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]>
…t-evm into fee-recipients-precompile
…t-evm into fee-recipients-precompile
ceyonur
requested review from
anusha-ctrl,
dasconnor,
darioush,
patrick-ogrady and
aaronbuchwald
as code owners
|
closing in favor of #383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Moves inline ABI strings in precompiles to embedded separate string files.
How this works
Changes how we handle
abi.Bindfunction and adds a hook to provide a way for expanding the function without expanding the standard inputs. Creates inputted ABI files in the same directory with output precompile file, and embeds those ABI files in precompile. If the output precompile file is STDOUT then it will inline ABI strings into the precompile (old behaviour).Changes precompile template to reflect those changes.
How this was tested
Created a RewardManager precompile with precompile gen tool and run
stateful_precompile_test.gotests. Also confirmed the ABI is inlined when output is STDOUT.