Coreth 0.11.6 sync #436
Merged
Coreth 0.11.6 sync #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
requested review from
anusha-ctrl,
darioush,
patrick-ogrady and
aaronbuchwald
as code owners
darioush
reviewed
Jan 17, 2023
|
great work, couple nits: |
darioush
approved these changes
Jan 19, 2023
Comment on lines
+38
to
+41
| defaultRegossipTxsPerAddress = 1 | ||
| defaultPriorityRegossipFrequency = 1 * time.Second | ||
| defaultPriorityRegossipMaxTxs = 32 | ||
| defaultPriorityRegossipTxsPerAddress = 16 |
There was a problem hiding this comment.
Can we migrate these to coreth as well?
There was a problem hiding this comment.
you mean priority regossiping?
aaronbuchwald
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Syncs coreth 0.11.6 changes
How this works
v0.11.3 was the last synced tag to subnet-evm (prior to this PR)
After applying the patch, then iterate manually over rejected files. at this point I preferred iterating over coreth diffs in a separate window and checked differences manually. I.e open 2 windows one:
1- within coreth that shows diffs between v0.11.3 to v0.11.6
2- subnet-evm
and compare missing differences in folders with those rejected files.
How this was tested
UTs should cover this.