Skip to content

fix allow list comments #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 31, 2023
Merged

fix allow list comments #469

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa14df1
fix allow list comments
ceyonur Jan 30, 2023
a4bf02f
cleaner sentences
ceyonur Jan 30, 2023
e93a98a
use preallocated big nums
ceyonur Jan 30, 2023
19260c5
infer allow list role type
ceyonur Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions precompile/allow_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ package precompile
import (
"errors"
"fmt"
"math/big"

"github.com/ava-labs/subnet-evm/vmerrs"
"github.com/ethereum/go-ethereum/common"
Expand All @@ -23,9 +22,12 @@ const (
)

var (
AllowListNoRole AllowListRole = AllowListRole(common.BigToHash(big.NewInt(0))) // No role assigned - this is equivalent to common.Hash{} and deletes the key from the DB when set
AllowListEnabled AllowListRole = AllowListRole(common.BigToHash(big.NewInt(1))) // Deployers are allowed to create new contracts
AllowListAdmin AllowListRole = AllowListRole(common.BigToHash(big.NewInt(2))) // Admin - allowed to modify both the admin and deployer list as well as deploy contracts
// No role assigned - this is equivalent to common.Hash{} and deletes the key from the DB when set
AllowListNoRole = AllowListRole(common.BigToHash(common.Big0))
// Enabled - allowed to use state-changing precompile functions without modifying status of other admins or enableds
AllowListEnabled = AllowListRole(common.BigToHash(common.Big1))
// Admin - allowed to modify both the admin and enabled list, as well as to use state-changing precompile functions
AllowListAdmin = AllowListRole(common.BigToHash(common.Big2))

// AllowList function signatures
setAdminSignature = CalculateFunctionSelector("setAdmin(address)")
Expand Down