-
Notifications
You must be signed in to change notification settings - Fork 268
Shared memory precompiles regen #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
darioush
wants to merge
35
commits into
precompile-pre-post-handling
from
shared-memory-precompiles-regen
Closed
Shared memory precompiles regen #536
darioush
wants to merge
35
commits into
precompile-pre-post-handling
from
shared-memory-precompiles-regen
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move inline string ABIs to separate files and embed them * fix tests * fix tests * unexport function * Update accounts/abi/bind/bind.go Co-authored-by: Darioush Jalali <[email protected]> * fix func name Co-authored-by: Darioush Jalali <[email protected]>
* rework on panics in precompiles * Update precompile/allow_list.go Co-authored-by: aaronbuchwald <[email protected]> * Update precompile/fee_config_manager.go Co-authored-by: aaronbuchwald <[email protected]> * Update precompile/fee_config_manager.go Co-authored-by: aaronbuchwald <[email protected]> * fix reviews * wrap errors in ConfigurePrecompiles * cleaner errors * Update utils.go * Update miner/worker.go Co-authored-by: aaronbuchwald <[email protected]> * Update core/state_processor.go Co-authored-by: aaronbuchwald <[email protected]> Co-authored-by: aaronbuchwald <[email protected]>
* rework on panics in precompiles * Update precompile/allow_list.go Co-authored-by: aaronbuchwald <[email protected]> * Update precompile/fee_config_manager.go Co-authored-by: aaronbuchwald <[email protected]> * Update precompile/fee_config_manager.go Co-authored-by: aaronbuchwald <[email protected]> * fix reviews * wrap errors in ConfigurePrecompiles * cleaner errors * move reward manager precompile to package (WIP) * rename files * fix abi path * move typecheck * move precompiles to their own packages * refactor precompile template * remove test file * upate comments * rm test files * new allowlist package * Update precompile/utils.go Co-authored-by: Darioush Jalali <[email protected]> * Update precompile/nativeminter/contract_native_minter.go Co-authored-by: Darioush Jalali <[email protected]> * Update precompile/nativeminter/contract_native_minter.go Co-authored-by: Darioush Jalali <[email protected]> * Update precompile/utils.go Co-authored-by: Darioush Jalali <[email protected]> * Update precompile/nativeminter/contract_native_minter.go Co-authored-by: Darioush Jalali <[email protected]> * fix nits Co-authored-by: aaronbuchwald <[email protected]> Co-authored-by: Darioush Jalali <[email protected]>
* rename struct * rename fee config managers to fee managers * fix comments
* introduce precompiles as registrable modules * add precompile specific contract tests * remove print debug * add unmarshal tests * remove unnecessary func * fix initial disabled value * register all modules in core/evm/contract_stateful * more refactor & test fix * sync template * fix more tests * rename file * add comment * rename * fix linter * use require error contains * remove whitespace * trim mock interface * sort steps * reviews * Update precompile/stateful_precompile_module.go * Update params/precompile_config.go * Update params/precompile_config.go * fix reviews * add new module to configs and group module functions * generalized-upgrades-rb review (#474) * keep genesis disabled fix * nits * nits * nit * review fixes * Update precompile/allowlist/allowlist.go * use address in map * fix linter for embedded keys * update err messages * more err update * remove unnecessary function (#478) * Start work on breaking cyclic dependency (#496) * Update core/state_processor.go * fix reviews * Update precompile/contracts/txallowlist/contract_test.go * Generalized upgrades rb nits0 (#512) * Minor improvements * restore readOnly * more updates * Add back readOnly to allow list tests
Co-authored-by: aaronbuchwald <[email protected]> Co-authored-by: Ceyhun Onur <[email protected]> Co-authored-by: Darioush Jalali <[email protected]> Co-authored-by: cam-schultz <[email protected]> Co-authored-by: Matthew Lam <[email protected]> Co-authored-by: cam-schultz <[email protected]> Co-authored-by: omahs <[email protected]> Co-authored-by: Anusha <[email protected]> Co-authored-by: Hagen Hübel <[email protected]> Co-authored-by: minghinmatthewlam <[email protected]> Fix: typos (#428) fix allow list comments (#469) fix CGO flags issue (#489) fix lint job (#499)
…bnet-evm into precompile-improvements-main
Co-authored-by: aaronbuchwald <[email protected]>
…bnet-evm into precompile-improvements-main
* alternative renaming for precompile configs * fixes * update naming * rename to AllowListConfig * simplify
* move blackhole check to module registerer * check blackhole first * add unit test * Add test case for registering module outside of reserved range --------- Co-authored-by: Aaron Buchwald <[email protected]>
ceyonur
added a commit
that referenced
this pull request
Apr 25, 2024
ceyonur
added a commit
that referenced
this pull request
Apr 29, 2024
* use less blocks to gen * avoid relying on rand.Seed for deterministic results (#535) * disable blobpool (#536) * add matrix and race to UTs (#530) * add matrix and race to UTs * remove unnecessary runners * clean script * lazy read bonus blocks * increase timeout * increase frequency * apply fix fow windows * increase timeout * disable fail fast * increase frequency and timeout * use latest * fix coma * better log * fix require * Fix formatting * fix eventually formats * test out new wg * Revert "test out new wg" This reverts commit 5d4a0a8a17bf78751163e948a6a65dd241b057aa. * check tx indexes after each block accept * mark as flaky * disable blobpool * add IsSubscribed for testing * remove subscribed when return * use atomic bool * attempt to fix flaky indexing test * use matrix for UTs * return if sub nil * add beacon root checks * fix test * return if sub nil --------- Co-authored-by: Darioush Jalali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.