Skip to content

fix issue when overwriting global interceptors #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2020
Merged

fix issue when overwriting global interceptors #258

merged 1 commit into from
May 1, 2020

Conversation

mercyaj
Copy link
Contributor

@mercyaj mercyaj commented Apr 29, 2020

Fixes #250

A fix was previously pushed in v1.0.8 (#251) that fixed the issue for options.headers but not for options.interceptors.

@iamthesiz
Copy link
Collaborator

@mercyaj mind writing a test for this? Here's one that you can build off of.

@iamthesiz
Copy link
Collaborator

I'll merge this for now and will ad a test later.

@iamthesiz iamthesiz merged commit dd0b1b5 into ava:master May 1, 2020
@iamthesiz
Copy link
Collaborator

should be fixed in v1.0.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting a global option persists for all instances
2 participants