Query Param Bugs

[kevind-wgu]

I was looking into avaje-http for javalin to see how it worked and ran across a few issues I thought I would mention.

    @Get("/{id}")
    public Job get(Integer id, @QueryParam("p1") String p1, @QueryParam("p2") Double p2, @QueryParam("p3") Integer p3, @QueryParam("p4") Float p4, String body) {
        return crudService.getRequired(id);
    }

produces this code

    ApiBuilder.get("/job/{id}", ctx -> {
      ctx.status(200);
      Integer id = asInteger(ctx.pathParam("id"));
      String p1 = ctx.queryParam("p1");
      Double p2 = ctx.bodyAsClass(Double.class);
      Integer p3 = toInteger(ctx.queryParam("p3"));
      Float p4 = toFloat(ctx.queryParam("p4"));
      String body = ctx.queryParam("body");
      // no validation required on p2
      ctx.json(controller.get(id, p1, p2, p3, p4, body));
    });

"p2" is being read via bodyAsClass rather than as a query param.
"p4" is being loaded with toFloat but the toFloat method doesn't exist. I am guessing it is supposed to be calling asFloat.

[rbygrave]

toFloat but the toFloat method doesn't exist. I am guessing it is supposed to be calling asFloat.

We need to add the missing toFloat() (and toDouble()) in that the toFloat() conversion allows nulls (for query parameters) and the asFloat() does not allow nulls (for path parameters).

So that's a bug and we need to add the missing toFloat() (and toDouble()).

[rbygrave]

Double p2 = ctx.bodyAsClass(Double.class);

That's a bug with missing registration to handle java.lang.Double (and actually primitive double was also missing).

[rbygrave]

Side note:

@Get("/{id}")
public Job get(Integer id, @QueryParam("p1") String p1, ...) {
    return crudService.getRequired(id);
}

Note that in the case of path parameters they must be not null. A InvalidPathArgumentException is thrown if they are found to be null or invalid.

What that means is that the case of the id path parameter above which is an Integer we note that we can make that a primitive int rather than object Integer. Generally I'd prefer int because it is communicating that it's never null.

[rbygrave]

Fixed those 2 bugs in master. Closing.