Skip to content

Change StackElementFilter into an interface and add a Builder for common filters #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

rob-bygrave
Copy link
Contributor

These common filters are in preparation for introducing "stackhash" and the desire to make that easy to configure and perform well.

…mon filters

These common filters are in preparation for introducing "stackhash" and the desire to make that easy to configure and perform well.
@rob-bygrave rob-bygrave requested a review from SentryMan January 14, 2025 00:29
The StackHasher used includes all the common stack element filtering such that it should produce a relatively stable hash.
…om fields

The evaluation uses system properties and environment variables to eval expressions
in the form ${key} and ${key:defaultValue}.

This also defaults the component in a K8s environment using the hostname.
@rbygrave rbygrave self-assigned this Jan 14, 2025
@rbygrave
Copy link
Contributor

I'm going to merge this and deploy it into a component.

@rbygrave rbygrave merged commit f61b106 into main Jan 14, 2025
7 checks passed
@rbygrave rbygrave deleted the feature/filter-as-interface branch January 14, 2025 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants