Further Support Null Analysis #47
Conversation
|
Alright, we're now good with both checker framework and nullaway. |
|
Yep, Just Works™. Very cool, thank you. :) |
hmm, yeah wasn't that hard to add |
|
I'm not keen on aspects of this PR because it adds a bunch of features that I'm not sure we want long term.
How do we feel about those features? |
I thought that was for static analysis. At runtime, the jspecify annotations do do much, so it'll be possible to slip nulls in undetected. EDIT: nevermind let's just jspecify
Forgot why I had it
ok
ok |
|
@rbygrave please review when you get time. EDIT: wait hang on |
|
@rbygrave please review and deploy an RC when you get time |
| * Return the AnnotationValue corresponding to the enforceNullSafety() member of the annotation, | ||
| * or null when the default value is implied. | ||
| */ | ||
| AnnotationValue enforceNullSafety() { |
There was a problem hiding this comment.
Rob to check this after merge.
| * Return the AnnotationValue corresponding to the builderInterfaces() member of the annotation, | ||
| * or null when the default value is implied. | ||
| */ | ||
| AnnotationValue builderInterfaces() { |
There was a problem hiding this comment.
Rob to check this after merge.
| this.components = components; | ||
| importTypes.add("io.avaje.recordbuilder.Generated"); | ||
| importTypes.add("java.util.function.Consumer"); | ||
| importTypes.add("java.util.function.Consumer"); |
There was a problem hiding this comment.
Double import line. Rob to check this after merge.
@NonNullis detected on a component, the generatedbuildmethod will validate that the value isn't null@NullMarkedand@NullUnmarkedResolves #43 (At least for the checker framework)
also has changes from #45