Use --verbose when testing CLI output #1477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It cannot be guaranteed that all lines output by the mini reporter are captured in the stderr of the CLI invocation during testing. Use --verbose when matching output that the mini reporter may otherwise rewrite. Somewhere on at least Node.js 8.2.1, when the package-lock.json is discarded prior to installation, something in our dependency tree is different which results in the test title no longer being in the stderr of the AVA CLI. Compare: ``` ⠋ ESC[2KESC[1AESC[2KESC[G ⠙ ESC[2KESC[1AESC[2KESC[G ⠹ ESC[2KESC[1AESC[2KESC[G ⠸ ESC[2KESC[1AESC[2KESC[G ⠼ ESC[2KESC[1AESC[2KESC[G ⠴ ESC[2KESC[1AESC[2KESC[G ⠦ ESC[2KESC[1AESC[2KESC[G ⠦ test › works… 1 passedESC[2KESC[1AESC[2KESC[1AESC[2KESC[1AESC[2KESC[G 1 passed [18:32:54] ``` Versus: ``` ⠋ ESC[2KESC[1AESC[2KESC[G ⠙ ESC[2KESC[1AESC[2KESC[G ⠹ ESC[2KESC[1AESC[2KESC[G ⠸ ESC[2KESC[1AESC[2KESC[G ⠼ ESC[2KESC[1AESC[2KESC[G ⠴ ESC[2KESC[1AESC[2KESC[G ⠴ … 1 passedESC[2KESC[1AESC[2KESC[1AESC[2KESC[1AESC[2KESC[G ⠦ … 1 passedESC[2KESC[1AESC[2KESC[1AESC[2KESC[1AESC[2KESC[G 1 passed [18:35:49] ```
|
See https://travis-ci.org/avajs/ava/jobs/258140018 for a failing test. |
This was referenced Jul 30, 2017
|
I guess it's caused by sindresorhus/cli-truncate@f379a0e |
|
Maybe. I suppose something removes spurious output that would get rewritten immediately? I don't think it's a problem if the mini reporter doesn't write that to stdout, and it only broke one test. Not sure if we should explicitly bump any dependencies? Regardless will merge this to unblock other PRs. |
Nah |
kevva
pushed a commit
that referenced
this pull request
Sep 13, 2017
It cannot be guaranteed that all lines output by the mini reporter are captured in the stderr of the CLI invocation during testing. Use --verbose when matching output that the mini reporter may otherwise rewrite. Somewhere on at least Node.js 8.2.1, when the package-lock.json is discarded prior to installation, something in our dependency tree is different which results in the test title no longer being in the stderr of the AVA CLI. Compare: ``` ⠋ ESC[2KESC[1AESC[2KESC[G ⠙ ESC[2KESC[1AESC[2KESC[G ⠹ ESC[2KESC[1AESC[2KESC[G ⠸ ESC[2KESC[1AESC[2KESC[G ⠼ ESC[2KESC[1AESC[2KESC[G ⠴ ESC[2KESC[1AESC[2KESC[G ⠦ ESC[2KESC[1AESC[2KESC[G ⠦ test › works… 1 passedESC[2KESC[1AESC[2KESC[1AESC[2KESC[1AESC[2KESC[G 1 passed [18:32:54] ``` Versus: ``` ⠋ ESC[2KESC[1AESC[2KESC[G ⠙ ESC[2KESC[1AESC[2KESC[G ⠹ ESC[2KESC[1AESC[2KESC[G ⠸ ESC[2KESC[1AESC[2KESC[G ⠼ ESC[2KESC[1AESC[2KESC[G ⠴ ESC[2KESC[1AESC[2KESC[G ⠴ … 1 passedESC[2KESC[1AESC[2KESC[1AESC[2KESC[1AESC[2KESC[G ⠦ … 1 passedESC[2KESC[1AESC[2KESC[1AESC[2KESC[1AESC[2KESC[G 1 passed [18:35:49] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It cannot be guaranteed that all lines output by the mini reporter are
captured in the stderr of the CLI invocation during testing. Use
--verbose when matching output that the mini reporter may otherwise
rewrite.
Somewhere on at least Node.js 8.2.1, when the package-lock.json is
discarded prior to installation, something in our dependency tree is
different which results in the test title no longer being in the stderr
of the AVA CLI.
Compare:
Versus: