Match anonymous tests when all of the match expressions are negative #1502
Conversation
lib/runner.js
Outdated
| @@ -112,7 +113,7 @@ class Runner extends EventEmitter { | |||
| } | |||
|
|
|||
| if (metadata.type === 'test' && this.match.length > 0) { | |||
| metadata.exclusive = title !== null && matcher([title], this.match).length === 1; | |||
| metadata.exclusive = title === null ? this.matchTitleless : matcher([title], this.match).length === 1; | |||
There was a problem hiding this comment.
I think it may be sufficient to remove the title !== null check. matcher([null],["!*oo"]) gives [null] which passes the length === 1 check. Perhaps use matcher([title || ''], this.match), since the matcher expects strings.
There was a problem hiding this comment.
I'm okay with that simplification, but you should know that it does change behavior—that would essentially treat a titleless test the same as a test with an empty string title, so -m '*' would truly include all tests, even the titleless ones, and there would no longer be an escape hatch to go back to the old behavior. I was trying to lean towards making this PR as conservative as possible, but I can't think of a real reason to want to distinguish between anonymous tests and empty title tests, so if you're fine with that then I'll make the change.
Yea me neither. I've scanned the discussion in #476 and I don't think we ever considered this. Generally we'd recommend against using anonymous tests, so if you do use them and need to somehow exclude them I guess you might just have to name them 😉 |
rhendric
force-pushed
the
fix/neg-match-anonymous
branch
from
4a722e8 to
feffe0d
Compare
|
So shall it be! |
|
why not default to the file path for the name of the test if no test title is given |
|
@ORESoftware we already display the title as "anonymous". This PR postulates that |
|
@novemberborn, ready to merge? |
(Matching on'*', for example, still excludes tests with no titles, as it did prior to this commit.)The motivation here is if I have a test suite with some anonymous tests and some titled tests, and some of the titled tests are tagged with something like
[long-running], and I want to runava -m '!*[long-running]*', I don't want to exclude the anonymous tests. But with current Ava they are excluded.For what it's worth, anyone who misses the old behavior could get it back with-m '*' -m <negative match expression(s)>.Edit: Changed so that
-m '*'matches all tests, including anonymous. For purposes of matching, anonymous tests have empty string titles.