Skip to content

Drop Node.js 4 & other housekeeping chores #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 2, 2018
Merged

Conversation

novemberborn
Copy link
Member

We're only a few weeks away from Node.js 4 reaching end-of-life. It's likely that Babel 7 will drop support, and it's also quite likely we won't ship the non-beta 1.0 release until after the cut-off. Consequently let's drop Node.js 4 now, rather than next month.

I've amended the support statement to allow for this circumstance:

We may drop support for a Node.js version, in a major-version-bumping-pre-release, if that new AVA version is expected to become stable around or after the end-of-life date of the Node.js version in question.

Let's hold off on aggressively rewriting code until the big 1.0 work completes.

Housekeeping wise I've upgraded npm to 5.8.0 so we can utilize the npm ci command. I'm still verifying the package-lock.json matches what npm in our CI environment generates, but the lock-verify step has been removed from our lint command.

Most dependencies have been updated, including TypeScript and Flow.


I'm going to land this once CI passes, so I can rebase #1722 and land that one too. Happy to make changes in response to feedback in a follow-up PR.

Disable XO rules that necessitate large code changes.
Ignore `cli-spinners` and `inquirer`, since #1722 removes them.

Ignore `git-branch`, since the benchmark utils are currently broken
(#1756).

Ignore `globby` as it has significant breaking changes.
@novemberborn novemberborn merged commit 4e24ece into master Apr 2, 2018
@novemberborn novemberborn deleted the drop-node-4 branch April 2, 2018 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants