Skip to content

fix t.log in hooks #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2019
Merged

fix t.log in hooks #2012

merged 1 commit into from
Jan 13, 2019

Conversation

dflupu
Copy link
Contributor

@dflupu dflupu commented Jan 12, 2019

Fixes #1536

I've looked into grouping per-test hook output with the test output, and while the changes necessary were rather trivial, there were a few downsides such as:

  • it would be inconsistent with the per-file hooks that would still not be grouped
  • it's rather confusing and unnecessary in practice
  • test results would not be printed until all of the after hooks finish

@dflupu dflupu force-pushed the fix-log-in-hooks branch 2 times, most recently from d3432ce to 3ed04c5 Compare January 12, 2019 19:59
@novemberborn
Copy link
Member

I've looked into grouping per-test hook output with the test output, and while the changes necessary were rather trivial, there were a few downsides such as:

  • it would be inconsistent with the per-file hooks that would still not be grouped
  • it's rather confusing and unnecessary in practice
  • test results would not be printed until all of the after hooks finish

Fair enough. I'd really like to revisit the reporters, we could improve this later.

Copy link
Member

@novemberborn novemberborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just retrying one CI run to see if the failure is intermittent, otherwise this looks great!

@novemberborn novemberborn merged commit d187712 into avajs:master Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants