-
Notifications
You must be signed in to change notification settings - Fork 1.4k
print pending tests on interrupt #2022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
20a97d7
to
8283ff8
Compare
Can't get that test working when ran during |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for another stellar PR @dflupu! Some refactoring may have unintended consequences though, see below.
Can't get that test working when ran during
npm test
.tap --no-cov test/integration/assorted.js
works fine. I assume the event loop is being blocked by something else.
I'll have a look (at some point).
test/integration/assorted.js
Outdated
t.end(); | ||
}); | ||
}); | ||
|
||
test('interrupt', t => { | ||
const proc = execCli(['long-running.js', '-T', '5s'], (err, stdout) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps remove the -T
argument to make it clearer this only deals with SIGINT
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed this test altogether since it didn't work during npm test
. For reference, here it was:
test('interrupt', t => {
const proc = execCli(['long-running.js'], (_, stdout) => {
t.match(stdout, /SIGINT/);
t.end();
});
setTimeout(() => {
proc.kill('SIGINT');
}, 2000);
});
8283ff8
to
4e87135
Compare
4e87135
to
befde13
Compare
@novemberborn Can you take a look at the replies above? I don't know if you get notifications for them so I figured I'd poke you in a separate comment. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd, I'm not sure why the SIGINT
test fails in CI. It passes locally. I've added it back but commented out. Hopefully it'll start to work at some point…
@dflupu You need to submit the PR URL to IssueHunt to claim the bounty: https://issuehunt.io/repos/26820798/issues/583 |
Fixes #583