wait for forked streams to end before resolving promise #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
npm install issue: npm/npm#9299 |
Tests are just too brittle on AppVeyor. `npm install` fails frequently, and Node on Windows does not seem to reliably flush stdout/stderr of forked child processes. I don't like this, but I'm at a loss for other solutions.
jamestalmage
force-pushed
the
wait-for-forked-streams
branch
from
d63265f to
11961f7
Compare
|
closing in favor of #206 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SEE #213 FIRST
Hopefully this will help w/ AppVeyor failures.