Skip to content

Create recipe "Debugging with node inspect" #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

rien
Copy link

@rien rien commented Dec 5, 2019

I had some trouble to get the node inspector to work with ava, but after digging trough the issues (e.g. #1505, #1108) I found you had to use the (undocumented) profile.js file.

This PR adds a recipe with some documentation of this method, so it's easier for people to find.

Copy link
Contributor

@forresst forresst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, I have some corrections and proposals.

If the recipe is accepted by the team, it will also be necessary to add a link in the README.md

@rien
Copy link
Author

rien commented Dec 6, 2019

Thanks for your review @forresst, I have applied your suggestions.

@novemberborn
Copy link
Member

Thanks for your PR @rien, I really do appreciate it.

profile.js is mentioned in some recipes, like https://github.com/avajs/ava/blob/fd73358d9ee85c3623a10acfebb5af88c51d628b/docs/recipes/debugging-with-chrome-devtools.md and https://github.com/avajs/ava/blob/0a5fe429ca37c025a15c5af919827436cc413abc/docs/recipes/debugging-with-vscode.md.

This is not something we want to promote further, however.

We have an open issue for a built-in debug mode instead: #1505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants