remove color from test title in mini reporter #618
Conversation
too much green when the result count is also in green and with `todo` and `skip` tests it doesn't matter as they're shown too fast anyways
|
By analyzing the blame information on this pull request, we identified @BarryThePenguin, @sotojuan and @naptowncode to be potential reviewers |
|
|
||
| if (test.todo) { | ||
| title = colors.todo('- ' + test.title); | ||
| this.todoCount++; |
There was a problem hiding this comment.
Why do we manually count these in the reporter? Shouldn't it be provided by the API?
There was a problem hiding this comment.
Agree, that should be changed.
There was a problem hiding this comment.
As I recall, the API does track this, but it's not provided until the finish event. The mini reporter is the only reporter that cares about the live count.
|
Just a thought, but what if we showed bothe the current test, and the last failed test. Or maybe just the counts and the last failed test (Since we intend to print pending tests on SIGINT - the last passed test isn't that valuable anymore). What failed is usually the most important info anyways. |
|
Let's continue this in #628. |
remove color from test title in mini reporter
too much green when the result count is also in green
and with
todoandskiptests it doesn't matter as they're shown too fast anyways