Skip to content

FYI: possible moving crate #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stappersg opened this issue Jun 10, 2022 · 2 comments
Closed

FYI: possible moving crate #44

stappersg opened this issue Jun 10, 2022 · 2 comments
Assignees

Comments

@stappersg
Copy link
Member

This is to share with you an observation of something that I didn't expect to see.

$ cargo update
    Updating git repository `https://github.com/avr-rust/ruduino`
    Updating crates.io index
    Updating git repository `https://github.com/avr-rust/delay`
    Updating avr_delay v0.4.0 (https://github.com/avr-rust/delay#cfe9848f) -> #6ba963c3
    Updating ruduino v0.4.0 (https://github.com/avr-rust/ruduino?branch=master#a33d38a7) -> #c113fc88
gs0604@trancilo:~/src/rust/RustAVR/blink
$

The #6ba963c3 is another (short) commit hash as of the 0.4.0 tag from crate avr_delay.

During build is again #6ba963c3 seen.

$ cargo build --release
   Compiling avr_delay v0.4.0 (https://github.com/avr-rust/delay#6ba963c3)
   Compiling ruduino v0.4.0 (https://github.com/avr-rust/ruduino?branch=master#c113fc88)
   Compiling blink v0.1.0 (/home/gs0604/src/rust/RustAVR/blink)
WARN rustc_codegen_ssa::back::link Linker does not support -no-pie command line option. Retrying without.
    Finished release [optimized] target(s) in 0.43s
$

It is #398d435 that goes with v0.4.0.

So it seems that blink builds with a moving crate, it should be build with stable crates.

Plan is to get https://github.com/avr-rust/ruduino/blob/master/Cargo.toml#L32 currently

avr_delay = { git = "https://github.com/avr-rust/delay", version = "0.4.0" }

back into something like:

avr_delay = "0.N"

Meanwhile be aware of this situation.

@stappersg stappersg self-assigned this Jun 10, 2022
@stappersg
Copy link
Member Author

afbeelding

@stappersg
Copy link
Member Author

Fixed in avr-rust/ruduino@61a8e0d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant