Skip to content

Use built-in target #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

n8henrie
Copy link
Contributor

@n8henrie n8henrie commented Jun 11, 2022

The built-in target works well and would make a reasonable default.

@stappersg
Copy link
Member

There are other microcontrollors with AVR instruction set as the atmega328p.

@n8henrie
Copy link
Contributor Author

n8henrie commented Jun 11, 2022

Sorry, can you make the issue more concrete?

I see the benefit here being that users of a very common microcontroller don't need to explicitly set the target with a separate json file, because a functional target its now built-in to rustc. Users of other or incompatible microcontrollers can continue doing what they currently do by using a separate json config file, but the default case will be simpler.

What do you see as the downside? EDIT: In concrete terms, what current workflow or use case would break or be made more difficult than the existing situation?

@stappersg
Copy link
Member

Make a new merge request.
Same as this MR.
The difference should be that avr-atmega328p.json is not removed.

(Karma bonus points for a more neutral commit message.)

@n8henrie
Copy link
Contributor Author

Make a new merge request.

Couldn't I just fix that issue within this PR?

@n8henrie
Copy link
Contributor Author

Karma bonus points for a more neutral commit message.

The commit message is fairly bland. Did you mean the body of the pull request (at the top of this page)? If so, I have edited that, restored the json file, and squashed the commits. Does this look okay?

@n8henrie n8henrie mentioned this pull request Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants