Skip to content

Conversation

sktimalsina
Copy link
Member

@sktimalsina sktimalsina commented Nov 9, 2022

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

  • Retry the test if it fails
  • Set maximum number of total failures
  • Set that test result is still fail even when a test passes on retry
  • Sign Out test cases

How did you test these changes?
(Please add a line here how the changes were tested)

  • Added Unit Tests
  • Added Integration Tests

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sktimalsina sktimalsina requested a review from a team as a code owner November 9, 2022 15:50
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Merging #2099 (0913a8b) into main (8953ee6) will decrease coverage by 2.21%.
The diff coverage is 45.57%.

@@             Coverage Diff              @@
##               main    #2099      +/-   ##
============================================
- Coverage     45.28%   43.07%   -2.22%     
- Complexity     2117     2549     +432     
============================================
  Files           541      739     +198     
  Lines         17770    24723    +6953     
  Branches       1718     2724    +1006     
============================================
+ Hits           8048    10650    +2602     
- Misses         9082    13010    +3928     
- Partials        640     1063     +423     

gpanshu
gpanshu previously approved these changes Nov 9, 2022
@sktimalsina sktimalsina enabled auto-merge (squash) November 9, 2022 18:12
div5yesh
div5yesh previously approved these changes Nov 9, 2022
@tylerjroach tylerjroach dismissed stale reviews from div5yesh and gpanshu via 49c6529 November 10, 2022 19:15
@tylerjroach tylerjroach changed the title chore: add retries to identify flaky tests chore: Test Additions and Faulty Test Detection Nov 10, 2022
@sktimalsina sktimalsina merged commit 75a944b into main Nov 11, 2022
@sktimalsina sktimalsina deleted the retry_flaky_test branch November 11, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants