Skip to content

Conversation

div5yesh
Copy link
Contributor

@div5yesh div5yesh commented Nov 14, 2022

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

  • send client metadata to service calls
  • make builder visible for Java code
  • add pinpoint endpoint id to missing service calls
  • add Java and Kotlin API options contract test
  • cleanup options classes

How did you test these changes?
(Please add a line here how the changes were tested)

  • Added Unit Tests
  • Added Integration Tests

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@div5yesh div5yesh marked this pull request as ready for review November 15, 2022 03:26
@div5yesh div5yesh requested a review from a team as a code owner November 15, 2022 03:26
@div5yesh div5yesh enabled auto-merge (squash) November 15, 2022 03:26
@tylerjroach
Copy link
Member

Thank for adding the contract tests

@div5yesh div5yesh merged commit 9a25914 into main Nov 15, 2022
@div5yesh div5yesh deleted the fix/metadata branch November 15, 2022 15:00
banji180 pushed a commit that referenced this pull request Dec 7, 2022
* fix(auth): add missing client and analytics metadata

* fix options classes and add java options tests

* fix test

* fix after rebase

* add inline builders and kotlin options tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants