Skip to content

Conversation

dengdan154
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

How did you test these changes?
(Please add a line here how the changes were tested)

  • Added Unit Tests
  • Added Integration Tests

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dengdan154 dengdan154 requested a review from a team as a code owner December 6, 2022 22:52
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Merging #2162 (790eeac) into main (37c712a) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 790eeac differs from pull request most recent head 6436b59. Consider uploading reports for the commit 6436b59 to get more accurate results

@@             Coverage Diff              @@
##               main    #2162      +/-   ##
============================================
- Coverage     43.33%   43.31%   -0.02%     
+ Complexity     2577     2576       -1     
============================================
  Files           742      742              
  Lines         24855    24855              
  Branches       2765     2765              
============================================
- Hits          10770    10767       -3     
- Misses        13007    13009       +2     
- Partials       1078     1079       +1     

gpanshu
gpanshu previously approved these changes Dec 7, 2022
@dengdan154 dengdan154 changed the title analytics test fail fix fix(analytics): fix failing test Dec 9, 2022
@dengdan154 dengdan154 changed the title fix(analytics): fix failing test chore: Ignore failing analytics test Dec 9, 2022
Copy link
Contributor

@tjleing tjleing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

15 commits 😅

@dengdan154 dengdan154 closed this Dec 20, 2022
@dengdan154 dengdan154 deleted the dengdan-3 branch December 20, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants