feat: node compatibility test #1416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: be16ddb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bombguy
requested review from
edwardfoyle,
sobolk,
Amplifiyer and
srquinn21
as code owners
edwardfoyle
reviewed
May 1, 2024
sobolk
reviewed
May 6, 2024
packages/integration-tests/src/test-project-setup/access_testing_project.ts
Outdated
Show resolved
Hide resolved
added 2 commits
May 6, 2024 10:08
sobolk
previously approved these changes
May 6, 2024
sobolk
approved these changes
May 6, 2024
|
The checks need to be updated with the new names that includes the matrix configurations post merge |
edwardfoyle
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We should be ensuring that our repo is able to install, build, and test using the specified node versions.
Issue number, if available:
Changes
setup_nodeaction to take innode-versioninputinstall,build,test_with_coveragee2e_deployment,e2e_create_amplifyglobal.cryptoworkaround for node > 20 as it is no longer needed.Corresponding docs PR, if applicable:
Validation
Checklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.