Skip to content

ci: pin verdaccio image version #10975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2023
Merged

ci: pin verdaccio image version #10975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,25 +26,25 @@ executors:
js-test-executor:
docker:
- image: cypress/included:12.4.1
- image: verdaccio/verdaccio
- image: verdaccio/verdaccio:5.20
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @iartemiev I'd recommend verdaccio/verdaccio:5 instead, otherwise you will miss future patches.

auth:
username: $DOCKERHUB_USERNAME
password: $DOCKERHUB_ACCESS_TOKEN
resource_class: large

# TODO: Update tests that use this image to use the updated `js-test-executor`
# After upgrading the Docker image to 12.4.1, we had to make several updates to our samples (see
# https://github.com/aws-amplify/amplify-js-samples-staging/pull/522).
# This is because our current implementation of setting network status in our E2E tests began to
# fail (i.e. this is no longer supported). We updated our samples to instead use the Reachability
# After upgrading the Docker image to 12.4.1, we had to make several updates to our samples (see
# https://github.com/aws-amplify/amplify-js-samples-staging/pull/522).
# This is because our current implementation of setting network status in our E2E tests began to
# fail (i.e. this is no longer supported). We updated our samples to instead use the Reachability
# component's helper function for setting network status
# (see https://github.com/aws-amplify/amplify-js/blob/main/packages/core/src/Util/Reachability.ts#L42-L54).
# However, several JS tests were still failing after attempting to remediate. An item has been
# However, several JS tests were still failing after attempting to remediate. An item has been
# added to the JS backlog for follow-up.
js-test-executor-prev:
docker:
- image: cypress/included:8.7.0
- image: verdaccio/verdaccio
- image: verdaccio/verdaccio:5.20
auth:
username: $DOCKERHUB_USERNAME
password: $DOCKERHUB_ACCESS_TOKEN
Expand All @@ -58,7 +58,7 @@ executors:
webkit-test-executor:
docker:
- image: mcr.microsoft.com/playwright:v1.30.0-focal
- image: verdaccio/verdaccio
- image: verdaccio/verdaccio:5.20
auth:
username: $DOCKERHUB_USERNAME
password: $DOCKERHUB_ACCESS_TOKEN
Expand Down Expand Up @@ -1581,10 +1581,10 @@ releasable_branches: &releasable_branches
minimal_browser_list: &minimal_browser_list
browser: [chrome, firefox]

# List of test browsers that are used in E2E tests where we want to also test browser APIs. For functionality that
# interacts with browser APIs (e.g. IndexedDB), use `extended_browser_list`. Includes Microsoft Edge. Note: WebKit
# is not included in this list because WebKit requires a different Docker image. Any test that uses this browser
# list should also test against WebKit.
# List of test browsers that are used in E2E tests where we want to also test browser APIs. For functionality that
# interacts with browser APIs (e.g. IndexedDB), use `extended_browser_list`. Includes Microsoft Edge. Note: WebKit
# is not included in this list because WebKit requires a different Docker image. Any test that uses this browser
# list should also test against WebKit.
extended_browser_list: &extended_browser_list
browser: [chrome, firefox, edge]

Expand Down Expand Up @@ -2601,4 +2601,4 @@ orbs:
- run-with-retry:
label: Start App
command: yarn web & wait-on http://localhost:19006 -t $MAX_WAIT_ON_TIMEOUT
# End Canary Orb
# End Canary Orb