feat(storage): sync multibucket to storagebrowser #13635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update parseAmplifyOutput * update bundle size * address comments * update bundle size
* update options and test * update assertion error & download test * update getUrl & getProp test * update remove and list tests * update multi-part tests * update list & download test * update more storage tests * update bundle size * address comments
* copy multibucket draft 1 * update copy with key and tests * update the path route * cleanup * update bundle size * address minor nits
…e-browser-sync-multi-buckets
AllanZhengYP
force-pushed
the
storage-browser-sync-multi-buckets
branch
from
6b736e1 to
048ea00
Compare
AllanZhengYP
requested review from
ukhan-amazon,
haverchuck,
cshfang,
jimblanc,
HuiSF and
a team
as code owners
israx
previously approved these changes
Jul 24, 2024
ashika112
reviewed
Jul 24, 2024
| ); | ||
| const { bucket: sourceBucket } = await resolveS3ConfigAndInput(amplify, { | ||
| path: input.source.path, | ||
| options: { ...input.source }, |
There was a problem hiding this comment.
if u dont send in credentials provider as options will it not fallback to singleton usage here? should we just have it as options on both source and destination
There was a problem hiding this comment.
Addressed in 4f9f9d8
ashika112
approved these changes
Jul 24, 2024
ashwinkumar6
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Merge the multibucket support to the storagebrowser branch. The only manual change is: 6e5b3c5
Issue #, if available
Description of how you validated changes
Unit test
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.