Skip to content

Conversation

tjleing
Copy link
Contributor

@tjleing tjleing commented Nov 4, 2022

TESTED!

Before:

  • no Pinpoint app id: creates SharedPreferences file with 515... name and random endpoint id , creates SharedPreferences file with 515... name and random endpoint id
  • with Pinpoint app id: creates or SharedPreferences file with 515... name and endpoint id , creates SharedPreferences file with 515... name and random endpoint id

After:

  • no Pinpoint app id: no SharedPreferences file, no Pinpoint endpoint passed with Cognito calls
  • with Pinpoint app id: creates or reads SharedPreferences file with 515... name and endpoint id , uses that endpoint with Cognito calls

Docs update

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tjleing tjleing marked this pull request as ready for review November 11, 2022 01:53
@tjleing tjleing requested a review from a team as a code owner November 11, 2022 01:53
Copy link
Member

@tylerjroach tylerjroach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have agreed upon this change because unfortunately Pinpoint SDK is sending a different endpointId than AWSMobileClient. If this were just a matter of constructing/creating the endpointId in a weird way, I would advocate to try and migrate that value correctly, but the issue here is that we already have an endpointId properly in use by the Pinpoint SDK, so there is no resolution other than beginning to use the correct endpointId.

@tjleing tjleing merged commit d7e669a into main Dec 19, 2022
@tjleing tjleing deleted the leint/fix-pinpoint-cognito-integration branch December 19, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants