Skip to content

updated findings from Nika #4836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -1484,10 +1484,5 @@
"Libre's",
"Pinia"
],
"flagWords": [
"hte",
"full-stack",
"Full-stack",
"Full-Stack"
]
"flagWords": ["hte", "full-stack", "Full-stack", "Full-Stack"]
}
2 changes: 1 addition & 1 deletion src/fragments/cli-install-block.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ npm install -g @aws-amplify/cli
<Block name="cURL (Mac and Linux)">

```bash
curl -sL https://aws-amplify.github.io/amplify-cli/install | bash && $SHELL
sudo npm install -g @aws-amplify/cli --unsafe-perm=true
```

</Block>
Expand Down
2 changes: 1 addition & 1 deletion src/fragments/lib-v1/storage/js/upload.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ async function onChange(e) {

<Callout>

Note: 'contentType' is metadata (saved under the key 'Content-Type') for the S3 object and does not determine the 'Type' in the AWS S3 Console. If a file extension is not provided in the key of the uploaded object, the S3 console's 'Type' field will be emitted. Otherwise, the 'Type' will be populated to match the given extension of the key. The behavior of how the S3 object is treated will be based on 'contentType' in the metadata and not the 'Type'.
Note: 'contentType' is metadata (saved under the key 'Content-Type') for the S3 object and does not determine the 'Type' in the AWS S3 Console. If a file extension is not provided in the key of the uploaded object, the S3 console's 'Type' field will be omitted. Otherwise, the 'Type' will be populated to match the given extension of the key. The behavior of how the S3 object is treated will be based on 'contentType' in the metadata and not the 'Type'.

For example: uploading a file with the key "example.jpg" will result in the 'Type' being set as "jpg", but the 'contentType' in metadata will determine it's behavior so setting it as "text/html" will result in the file being treated as an HTML file regardless of displayed 'Type' in the S3 console.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ After the project information is filled, you will be prompted to select the AWS
Please choose the profile you want to use (Use arrow keys)
> default
```
> Where possible the CLI will infer the proper configuration based on the type of project Amplify is being initialized in. In this case it knew you are using Create React App and provided the proper configuration for type of app, framework, source, distribution, build, and start options.

> Where possible, the CLI will infer the proper configuration based on the type of project Amplify is being initialized in. In this case, it knew you are using a Flutter app, source, distribution, build, and start options.

Upon successfully running `amplify init`, you will see a configuration file created in `./lib/` called `amplifyconfiguration.dart`.

Expand Down
2 changes: 1 addition & 1 deletion src/fragments/lib/storage/js/browser-uploads.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ async function onChange(e) {

<Callout>

Note: 'contentType' is metadata (saved under the key 'Content-Type') for the S3 object and does not determine the 'Type' in the AWS S3 Console. If a file extension is not provided in the key of the uploaded object, the S3 console's 'Type' field will be emitted. Otherwise, the 'Type' will be populated to match the given extension of the key. The behavior of how the S3 object is treated will be based on 'contentType' in the metadata and not the 'Type'.
Note: 'contentType' is metadata (saved under the key 'Content-Type') for the S3 object and does not determine the 'Type' in the AWS S3 Console. If a file extension is not provided in the key of the uploaded object, the S3 console's 'Type' field will be omitted. Otherwise, the 'Type' will be populated to match the given extension of the key. The behavior of how the S3 object is treated will be based on 'contentType' in the metadata and not the 'Type'.

For example: uploading a file with the key "example.jpg" will result in the 'Type' being set as "jpg", but the 'contentType' in metadata will determine it's behavior so setting it as "text/html" will result in the file being treated as an HTML file regardless of displayed 'Type' in the S3 console.

Expand Down