feat: enable raw HTML strings in sidenav links #4930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I. Love. It. |
timngyn
added
the
amplify/docs-engineering
timngyn
suggested changes
Dec 9, 2022
There was a problem hiding this comment.
Hey @josefaidt, thank you for this! I think some of the tests are failing because you updated directory.js. I think the tests might need to be updated to handle the new require() statement you added.
jacoblogan
approved these changes
Dec 14, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR aims to enable the usage of raw HTML strings inside
directory.jsin order to render inline code blocks inside sidenav link items.It introduces a use of
dangerouslySetInnerHTMLin the DirectoryGroup class component, however it first validates whether the supplied string contains an inline code block.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.