Skip to content

Conversation

vimode
Copy link
Contributor

@vimode vimode commented Feb 4, 2023

This PR fixes some broken links in the docs pages.

Resolves #5076
Update the relative link to the correct data-model documentation page.

Resolves #5081
The cache page for react-native docs was missing from the Sidebar menu / secondary nav.
I wasn't certain how it was being mapped but from what I could gather is it was through the filters in the directory.js file. If thats incorrect, let me know I can roll the changes back.

Checks

  • Does this PR conform to the styleguide?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://link.com)
    HTML: <a href="https://link.com">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vimode vimode requested a review from a team as a code owner February 4, 2023 13:40
@timngyn timngyn added amplify/studio Issues and PRs related to amplify studio documentation react-native amplify/js Issues tied to JS labels Feb 6, 2023
@timngyn timngyn requested a review from a team February 7, 2023 18:46
@katieklein katieklein requested a review from a team February 15, 2023 20:13
@timngyn timngyn requested a review from a team February 16, 2023 21:32
@jacoblogan jacoblogan added the run-tests Label to run tests on PRs from a fork label Feb 16, 2023
@github-actions github-actions bot removed the run-tests Label to run tests on PRs from a fork label Feb 16, 2023
Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacoblogan jacoblogan merged commit 7bfde18 into aws-amplify:main Feb 16, 2023
@vimode vimode deleted the fix/broken-links branch February 17, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amplify/js Issues tied to JS amplify/studio Issues and PRs related to amplify studio documentation external-contributor react-native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feedback]Cache page exists for React Native but doesn't show up in sidebar [missing-page] on Data model
6 participants