Skip to content

feat(data): update PR template with E2E test check for code examples; update docs link example to point to an Amplify-owned resource #5161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

feat(data): update PR template with E2E test check for code examples; update docs link example to point to an Amplify-owned resource #5161

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8453411
feat(data): update PR template with E2E test check for code examples
david-mcafee Feb 27, 2023
3cc6dbe
fix: update docs link example to point to an Amplify-owned resource
david-mcafee Feb 27, 2023
d66b60a
Update .github/PULL_REQUEST_TEMPLATE.md
david-mcafee Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,15 @@
**If this PR should not be merged upon approval for any reason, please submit as a DRAFT**

Which product(s) are affected by this PR (if applicable)?

- [ ] amplify-cli
- [ ] amplify-ui
- [ ] amplify-studio
- [ ] amplify-hosting
- [ ] amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

- [ ] JS
- [ ] iOS
- [ ] Android
Expand All @@ -30,11 +32,12 @@ Which platform(s) are affected by this PR (if applicable)?

- [ ] Are any files being deleted with this PR? If so, have the needed redirects been created?

- [ ] Are all links in MDX files using the MDX link syntax rather than HTML link syntax? <br />
_ref: MDX: `[link](https://link.com)`
HTML: `<a href="https://link.com">link</a>`_
Comment on lines -34 to -35
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link.com is an actual website, but not owned by Amplify.

- [ ] Are all links in MDX files using the MDX link syntax rather than HTML link syntax? <br /> _ref: MDX: `[link](https://docs.amplify.aws)` HTML: `<a href="https://docs.amplify.aws">link</a>`_

- [ ] Does this PR include new and / or updated code examples? If so, please add E2E tests for those samples and link them in this PR.

### When this PR is ready to merge, please check the box below

- [ ] Ready to merge

_By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license._