Skip to content

Conversation

mmaeng
Copy link
Contributor

@mmaeng mmaeng commented Apr 27, 2023

Closes #105

Update typescript templates to use NodeJS 18.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (79e331b) 98.56% compared to head (d4c899a) 98.56%.

❗ Current head d4c899a differs from pull request most recent head 330217d. Consider uploading reports for the commit 330217d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files          14       14           
  Lines        1250     1250           
  Branches      209      209           
=======================================
  Hits         1232     1232           
  Misses         17       17           
  Partials        1        1           
Flag Coverage Δ
unittests 98.56% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/rpdk/typescript/codegen.py 98.75% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@ericzbeard ericzbeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but what are all the GitHub Actions warnings?

@mmaeng
Copy link
Contributor Author

mmaeng commented Apr 28, 2023

Looks good but what are all the GitHub Actions warnings?

They all look to be from the unit tests for the typescript-lib. All the ones I've seen look to be saying don't use the "any" type and use something more rigorous.

@dyangelo-grullon
Copy link

Can this be merged?

@mmaeng
Copy link
Contributor Author

mmaeng commented May 30, 2023

Can this be merged?

Unfortunately I can't approve my own PR :) Should get this merged in shortly.

@mmaeng mmaeng merged commit 618b591 into aws-cloudformation:master May 31, 2023
@mmaeng mmaeng deleted the nodejs18 branch May 31, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeJS 14.x deprecation
4 participants