Skip to content

Conversation

jj22ee
Copy link
Contributor

@jj22ee jj22ee commented Sep 9, 2025

Issue #, if available:
aws-observability/aws-otel-python-instrumentation#458

Description of changes:

  1. Remove new regions from COMMERCIAL_REGIONS
  2. Rename COMMERCIAL_REGIONS to LEGACY_COMMERCIAL_REGIONS
  3. Add comments for clarity

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jj22ee jj22ee requested a review from a team as a code owner September 9, 2025 22:04
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.07%. Comparing base (09e6487) to head (fc33227).
⚠️ Report is 493 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1185       +/-   ##
=============================================
- Coverage     85.71%   67.07%   -18.64%     
- Complexity       19      525      +506     
=============================================
  Files             3       54       +51     
  Lines            49     2694     +2645     
  Branches          5      376      +371     
=============================================
+ Hits             42     1807     +1765     
- Misses            3      750      +747     
- Partials          4      137      +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jj22ee jj22ee added the skip changelog doesn't need a CHANGELOG entry label Sep 17, 2025
@jj22ee jj22ee enabled auto-merge (squash) September 17, 2025 20:16
@jj22ee jj22ee merged commit 634b267 into aws-observability:main Sep 17, 2025
6 checks passed
jj22ee added a commit that referenced this pull request Sep 18, 2025
*Issue #, if available:*
- Original issue in Python Lambda release
aws-observability/aws-otel-python-instrumentation#458
- The new regions should be added to the default list, not the
commercial region env variable

*Description of changes:*
- Cherry-pick
#1185
from main

```
    Remove new regions from COMMERCIAL_REGIONS
    Rename COMMERCIAL_REGIONS to LEGACY_COMMERCIAL_REGIONS
    Add comments for clarity
```

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog doesn't need a CHANGELOG entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants