Skip to content

Maintenance: Implement PEP 612 (ParamSpec) for Logger #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
heitorlessa opened this issue Nov 14, 2022 · 1 comment
Closed
1 of 2 tasks

Maintenance: Implement PEP 612 (ParamSpec) for Logger #1711

heitorlessa opened this issue Nov 14, 2022 · 1 comment
Labels
tech-debt Technical Debt tasks

Comments

@heitorlessa
Copy link
Contributor

Summary

With typing_extension being now a runtime dependency, we can more accurately type decorators to allow signature change.

Quick blog on UX: https://sobolevn.me/2021/12/paramspec-guide

Why is this needed?

Customers using Pydantic or Event Source Data Class decorators to override Event type fail Mypy when using with logger.inject_lambda_context decorator, since it expects a Dict as its first argument.

Example: #1583

Which area does this relate to?

Logger

Solution

No response

Acknowledgment

@heitorlessa heitorlessa added triage Pending triage from maintainers internal Maintenance changes labels Nov 14, 2022
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Feb 13, 2023
@heitorlessa heitorlessa added tech-debt Technical Debt tasks and removed internal Maintenance changes labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Technical Debt tasks
Projects
None yet
Development

No branches or pull requests

1 participant