Skip to content

feat(data_classes): Add missing Bounce, S3 and WorkMail for SESEvent #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Feb 13, 2022

Issue #, if available:

Description of changes:

Change:

  • Add missing docs for SESReceiptStatus status field
  • Add response builder for disposition (disposition_response)
  • Add missing fields for Bounce, S3 and WorkMail actions

Source

Both DotNet, Go and Typescript lambda events projects has included these additional fields and event types for S3 and SNS:

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Change:
- Add missing fields from SESMailCommonHeaders
- Fix date type to be a str
- Add missing docs for SESReceiptStatus status field
- Add missing topicArn
- Add missing fields for Bounce, S3 and WorkMail actions

close aws-powertools#1025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 13, 2022
@github-actions github-actions bot added the bug Something isn't working label Feb 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2022

Codecov Report

Merging #1026 (cc61d55) into develop (2302099) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1026   +/-   ##
========================================
  Coverage    99.88%   99.88%           
========================================
  Files          119      119           
  Lines         5423     5452   +29     
  Branches       618      619    +1     
========================================
+ Hits          5417     5446   +29     
  Misses           2        2           
  Partials         4        4           
Impacted Files Coverage Δ
...bda_powertools/utilities/data_classes/ses_event.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bd8722...cc61d55. Read the comment docs.

@michaelbrewer
Copy link
Contributor Author

@heitorlessa - i just want to get verification on the action types supported (aka Stop, Bounce, S3 and WorkMail actions)

@jogold
Copy link

jogold commented Feb 16, 2022

@michaelbrewer you contacted me on Twitter. You mean this https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/aws-lambda/test/ses-tests.ts?

@michaelbrewer
Copy link
Contributor Author

@michaelbrewer you contacted me on Twitter. You mean this https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/aws-lambda/test/ses-tests.ts?

Yes @jogold both Lex V2 and SES event documentation does not include real examples with these missing fields.

@heitorlessa heitorlessa added revisit-in-3-months Requires more customers feedback before making or revisiting a decision need-customer-feedback Requires more customers feedback before making or revisiting a decision do-not-merge labels Feb 25, 2022
@michaelbrewer
Copy link
Contributor Author

michaelbrewer commented Feb 26, 2022

@heitorlessa - should we remove this data class ? Or at least fix the following

  • Fix date type to be a str and not List[str]
  • Add missing fields from SESMailCommonHeaders (bcc, cc, sender and replyTo)
  • Add missing docs for SESReceiptStatus status field
  • Add missing topicArn from all actions

@michaelbrewer
Copy link
Contributor Author

Superseded by #1045

@michaelbrewer michaelbrewer reopened this Apr 28, 2022
@michaelbrewer michaelbrewer changed the title fix(data_classes): Add missing fields for SESEvent feat(data_classes): Add missing SNS and S3 for SESEvent Apr 29, 2022
@github-actions github-actions bot added the feature New feature or functionality label Apr 29, 2022
@michaelbrewer michaelbrewer changed the title feat(data_classes): Add missing SNS and S3 for SESEvent feat(data_classes): Add missing Bounce, S3 and WorkMail for SESEvent Apr 29, 2022
@sthulb sthulb closed this Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working do-not-merge feature New feature or functionality need-customer-feedback Requires more customers feedback before making or revisiting a decision revisit-in-3-months Requires more customers feedback before making or revisiting a decision size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants