-
Notifications
You must be signed in to change notification settings - Fork 429
feat(data_classes): Add missing Bounce, S3 and WorkMail for SESEvent #1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change: - Add missing fields from SESMailCommonHeaders - Fix date type to be a str - Add missing docs for SESReceiptStatus status field - Add missing topicArn - Add missing fields for Bounce, S3 and WorkMail actions close aws-powertools#1025
Codecov Report
@@ Coverage Diff @@
## develop #1026 +/- ##
========================================
Coverage 99.88% 99.88%
========================================
Files 119 119
Lines 5423 5452 +29
Branches 618 619 +1
========================================
+ Hits 5417 5446 +29
Misses 2 2
Partials 4 4
Continue to review full report at Codecov.
|
@heitorlessa - i just want to get verification on the action types supported (aka |
@michaelbrewer you contacted me on Twitter. You mean this https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/aws-lambda/test/ses-tests.ts? |
Yes @jogold both Lex V2 and SES event documentation does not include real examples with these missing fields. |
@heitorlessa - should we remove this data class ? Or at least fix the following
|
Superseded by #1045 |
…1027)" (aws-powertools#1190) This reverts commit 797a10a.
Issue #, if available:
date
field typing and add missing fields #1025Description of changes:
Change:
SESReceiptStatus
status fielddisposition_response
)Bounce
,S3
andWorkMail
actionsSource
Both DotNet, Go and Typescript lambda events projects has included these additional fields and event types for S3 and SNS:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.