fix(logger): clear_state should keep custom key formats #1095
+23
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1084
Description of changes:
When using
clear_state=True
, overriden formats for standard logging keys likelocation
andtimestamp
was being overriden with the default formats. Overriding the formats are explained in the docs like this:Issue was that when
clear_state=True
was used, the default keys were reset to their defaults (by the fix implemented in #1088). This fix saves the formatting keys on instantiation and uses those instead whenclear_state
is called.Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.