docs(tracer): split and lint code snippets #1260
Merged
+57
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1009
Summary
Changes
This PR splits code snippets into a top-level
examples
folder. Formatting and linting (make lint
) were adjusted to includeexamples
folder. We also introduce cfn-lint within pre-commit hooks to selectively lint changed infra files withinexamples
folder.The only downside is that documentation needs to be rebuilt/rerun when example files are changed, as live change won't reflect files that are included.
Convention
We'll keep all examples under
examples
folder. Each feature will have its own source code that match what's in the documentation, followed by one or more infrastructure as code customers could use in the future.Example for Tracer
Caveat
We need to ensure Lambda Powertools dependency/layer is used. In the case of Layers, we will need to upgrade the Layer version within
examples
as part of each release - @am29d your input is crucial here on the best way forward. Until Alex completes his Layer pipeline refactoring, we can build a workflow action to find/replace Layer ARN Version.Another caveat is that
cfn-lint
dropped support for 3.6. We're using an officialcfn-lint
GitHub Actions as a workaround.User experience
Example of adding an invalid SAM template for a code snippet
Code quality example using our set of rules
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
View rendered docs/core/tracer.md