Skip to content

Maintenance: consolidate IdempotencyHandler implementation #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Jun 19, 2023 · 2 comments · Fixed by #1642
Closed
1 of 2 tasks

Maintenance: consolidate IdempotencyHandler implementation #1508

dreamorosi opened this issue Jun 19, 2023 · 2 comments · Fixed by #1642
Assignees
Labels
completed This item is complete and has been merged/shipped idempotency This item relates to the Idempotency Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Summary

The Idempotency utility heavily relies on a class called IdempotencyHandler. This component contains the implementation for the idempotency logic and is expected to be used by all other Idempotency frontends (aka higher-order function, middleware, decorators).

Currently the Middy middleware implementation for Idempotency doesn't use the IdempotencyHandler class fully, which causes some of the logic being duplicated. This tech debt was assumed because the IdempotencyHandler was modelled after the Python implementation, which didn't take in account the Middy lifecycle.

Why is this needed?

To reduce tech debt and avoid code duplication, which converts in maintenance overhead.

Which area does this relate to?

Idempotency

Solution

Modify the IdempotencyHandler so that it exposes more granular methods that will allow the Middy middleware to offer idempotency according to its programming model, without having to reimplement the same logic.

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) idempotency This item relates to the Idempotency Utility confirmed The scope is clear, ready for implementation labels Jun 19, 2023
@dreamorosi dreamorosi added this to the Idempotency - GA Release milestone Jun 22, 2023
@dreamorosi dreamorosi added the help-wanted We would really appreciate some support from community for this one label Jul 31, 2023
@dreamorosi dreamorosi moved this from Backlog to Working on it in Powertools for AWS Lambda (TypeScript) Aug 1, 2023
@dreamorosi dreamorosi self-assigned this Aug 1, 2023
@dreamorosi dreamorosi removed the help-wanted We would really appreciate some support from community for this one label Aug 1, 2023
@dreamorosi dreamorosi linked a pull request Aug 1, 2023 that will close this issue
9 tasks
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (TypeScript) Aug 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Aug 3, 2023
@github-actions
Copy link
Contributor

This is now released under v1.13.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Sep 18, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped idempotency This item relates to the Idempotency Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
Development

Successfully merging a pull request may close this issue.

1 participant