Skip to content

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR follows #1978 and makes additional changes to the workflows, namely:

  • remove the contents: write permission from the workflow used to make v2 releases since there's no commit
  • remove actions: write from the docs-related workflows - initially I thought this was needed but looking at other workflows that are known to be working (i.e. reusable_export_pr_details) and that also upload artifacts, I don't think it's actually needed
  • correct workflow reference in workflow (fixes issue I introduced in previous PR after renaming)
  • reduce permission scope of Layers workflow

Related issues, RFCs

Issue number: #1799

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Jan 26, 2024
@dreamorosi dreamorosi requested a review from a team January 26, 2024 17:06
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Jan 26, 2024
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Jan 26, 2024
@dreamorosi dreamorosi requested a review from am29d January 26, 2024 18:12
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@am29d am29d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@am29d am29d merged commit b387926 into main Jan 29, 2024
@am29d am29d deleted the chore/scorecard_fixes branch January 29, 2024 08:47
@dreamorosi dreamorosi linked an issue Jan 30, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation size/S PR between 10-29 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: review and restore PR automation
2 participants