Skip to content

docs(idempotency): fix descriptions in Advanced table #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 25, 2024
Merged

docs(idempotency): fix descriptions in Advanced table #3092

merged 5 commits into from
Sep 25, 2024

Conversation

garysassano
Copy link
Contributor

@garysassano garysassano commented Sep 20, 2024

Summary

Changes

Please provide a summary of what's being changed

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: #3098


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@garysassano garysassano requested a review from a team September 20, 2024 00:50
@garysassano garysassano requested a review from a team as a code owner September 20, 2024 00:50
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Sep 20, 2024
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Sep 20, 2024
Copy link

boring-cyborg bot commented Sep 20, 2024

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

@garysassano garysassano changed the title Fix description in idempotency.md docs(idempotency): Fix description in idempotency.md Sep 20, 2024
@garysassano garysassano changed the title docs(idempotency): Fix description in idempotency.md docs(idempotency): fix description for payloadValidationJmespath Sep 20, 2024
@garysassano garysassano changed the title docs(idempotency): fix description for payloadValidationJmespath docs(idempotency): fix descriptions in advanced table Sep 20, 2024
@pull-request-size pull-request-size bot added size/S PR between 10-29 LOC and removed size/XS PR between 0-9 LOC labels Sep 20, 2024
@garysassano garysassano changed the title docs(idempotency): fix descriptions in advanced table docs(idempotency): fix descriptions in Advanced table Sep 20, 2024
Copy link
Contributor

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Sep 20, 2024
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening the PR!

I have left a comment in one of the fields that I'd like to reword.

Also, the automation is complaining because the PR doesn't have any linked issue. Please open one and I'll link them. For future reference, here you have the process for contributions.

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.

Unverified

The signature in this commit could not be verified. Someone may be trying to trick you.
@garysassano
Copy link
Contributor Author

@dreamorosi I implemented your suggestion, and opened a PR to fix also Python's docs: aws-powertools/powertools-lambda-python#5191

@dreamorosi dreamorosi removed the do-not-merge This item should not be merged label Sep 25, 2024
Copy link

@dreamorosi dreamorosi merged commit 05c16e5 into aws-powertools:main Sep 25, 2024
15 checks passed
Copy link

boring-cyborg bot commented Sep 25, 2024

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation need-issue This PR needs an issue before it can be reviewed/worked on further size/S PR between 10-29 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Improve parameter descriptions in Idempotency Advanced table
2 participants