Skip to content

Conversation

sdangol
Copy link
Contributor

@sdangol sdangol commented Sep 23, 2025

Summary

This PR updates the Middleware and the RouteHandler types to move the params key under the RequestContext parameter.

Changes

Please provide a summary of what's being changed

  • Removed the params from the Middleware and the RouteHandler types and added to the RequestContext parameter.
  • Updated the occurrences to remove the params key and use it through the reqCtx property

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #4531


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

…r the RequestObject and changed the handler signature to do the same
@boring-cyborg boring-cyborg bot added event-handler This item relates to the Event Handler Utility tests PRs that add or change tests labels Sep 23, 2025
@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Sep 23, 2025
@sdangol sdangol self-assigned this Sep 23, 2025
Copy link

@sdangol sdangol marked this pull request as draft September 23, 2025 08:03
@sdangol sdangol marked this pull request as ready for review September 23, 2025 08:12
@sdangol sdangol merged commit 278fca0 into main Sep 23, 2025
45 checks passed
@sdangol sdangol deleted the improv/middleware-param branch September 23, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event-handler This item relates to the Event Handler Utility size/M PR between 30-99 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Change path parameter in the Middleware signature
2 participants