-
Notifications
You must be signed in to change notification settings - Fork 8
Add project metadata #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project metadata #364
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,22 @@ description = "Amazon Web Services (AWS) Advanced Python Wrapper" | |
authors = ["Amazon Web Services"] | ||
readme = "README.md" | ||
license = "Apache-2.0" | ||
include = ["CONTRIBUTING.md"] | ||
repository = "https://github.com/awslabs/aws-advanced-python-wrapper" | ||
documentation = "https://github.com/awslabs/aws-advanced-python-wrapper/docs/" | ||
classifiers = [ | ||
"Development Status :: 5 - Production/Stable", | ||
"Intended Audience :: Developers", | ||
"Natural Language :: English", | ||
"License :: OSI Approved :: Apache Software License", | ||
"Programming Language :: Python", | ||
"Programming Language :: Python :: 3", | ||
"Programming Language :: Python :: 3 :: Only", | ||
"Programming Language :: Python :: 3.8", | ||
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should I add 3.12 even though we don't test it? I know boto3 supports 3.12 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can skip 3.12 for now |
||
] | ||
|
||
[tool.poetry.dependencies] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if we have our optional/extra dependencies set up correctly for packaging, my main confusion is there are two concepts in poetry: dependency groups and extras. In the poetry docs they use dependency groups to separate out the test dependencies, but they also say extras should be used for optional dependencies that enhance a package but are not required. There's also this SO post but I'm still not sure if dependency groups or extras should be used (or both) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can't use both dependency groups and extras at the same time. |
||
python = "^3.8.1" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a reason this is ^3.8.1 instead of ^3.8 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think there was a particular reason |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, this would try to load pyproject.toml at the current working directory. So running pytest from the project root worked but running it from inside tests/unit did not