Skip to content

fix(logs-destinations): missing dependency to Policy created by KinesisDestination #24811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 28, 2023
Merged

fix(logs-destinations): missing dependency to Policy created by KinesisDestination #24811

merged 7 commits into from
Mar 28, 2023

Conversation

joel-aws
Copy link
Contributor

Fixes #21827

All credit to @pv93 for their fix.

@aws-cdk-automation aws-cdk-automation requested a review from a team March 28, 2023 01:17
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Mar 28, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@joel-aws joel-aws changed the title fix(aws-logs-destination): missing dependency to policy created by kinesisdestination fix(logs-destinations): missing dependency between subscriptionfilter & policy created by kinesisdestination Mar 28, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 28, 2023 01:29

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@joel-aws joel-aws changed the title fix(logs-destinations): missing dependency between subscriptionfilter & policy created by kinesisdestination fix(logs-destinations): missing dependency to Policy created by KinesisDestination Mar 28, 2023
@TheRealAmazonKendra
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2023

update

✅ Branch has been successfully updated

@TheRealAmazonKendra
Copy link
Contributor

No need to manually merge from main. I only updated this because I thought the build failure was a false failure due to an unrelated issue. If you ever do need to update the PR, please use @Mergifyio update instead.

TheRealAmazonKendra
TheRealAmazonKendra approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for your contribution!

@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e661ffb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3c98d1e into aws:main Mar 28, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

homakk pushed a commit to homakk/aws-cdk that referenced this pull request Mar 28, 2023
@joel-aws @homakk
fix(logs-destinations): missing dependency to Policy created by Kines…
7ed722f 
…isDestination (aws#24811)

Fixes aws#21827

All credit to @pv93 for [their fix](aws#21827 (comment)).
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-logs-destinations: missing dependency to Policy created by KinesisDestination
3 participants
@joel-aws @TheRealAmazonKendra @aws-cdk-automation