Skip to content

chore(cognito-identitypool): make role attachment resource public #34234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2025

Conversation

Leo10Gama
Copy link
Member

Issue # (if applicable)

N/A

Reason for this change

In order to allow for more flexibility when configuring Identity Pool resources, one may need to override attributes in the role attachment. To make this process easier, we should be able to access this resource the same way as we would access the L2 resource.

Description of changes

  // private readonly roleAttachment: IdentityPoolRoleAttachment;
  public readonly roleAttachment: IdentityPoolRoleAttachment;

Describe any new or updated permissions being added

N/A

Description of how you validated changes

yarn build && yarn test aws-cognito-identitypool

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 23, 2025 21:37
@github-actions github-actions bot added the p2 label Apr 23, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 23, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ce4f117
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 23, 2025
@shikha372 shikha372 self-assigned this Apr 23, 2025
Copy link
Contributor

mergify bot commented Apr 23, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 87e1add into aws:main Apr 23, 2025
19 of 20 checks passed
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants