Syncing - Internal repo changes. #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Fedramp compliance, we need to enable customers to use Fips vips. By setting this option in the configuration file, they can make the Agent use the ADCS Fips vips. cr https://code.amazon.com/reviews/CR-3463212
To support Fedramp requirements, we connect to S3 using its Fips endpoints if use_fips_mode is set to true
…hips with Ruby 2.5.x." This reverts commit 92ad4e3. cr https://code.amazon.com/reviews/CR-3966728
annamataws
suggested changes
Nov 29, 2018
| @@ -65,5 +70,39 @@ class InstanceAgentConfigTest < InstanceAgentTestCase | |||
| assert InstanceAgent::Config.validate_config.empty?, InstanceAgent::Config.validate_config.inspect | |||
| end | |||
| end | |||
|
|
|||
| context 'validate use_fips_mode' do | |||
There was a problem hiding this comment.
Why only these 4 regions? why not all 6 from the list above?
There was a problem hiding this comment.
FIPS was deployed to be used only in gov regions or some regions that we were running some tests.
There was a problem hiding this comment.
You have
FIPS_ENABLED_REGIONS = Set['us-east-1', 'us-east-2', 'us-west-1', 'us-west-2', 'us-gov-west-1', 'us-gov-east-1']
above
Why are only 4 of those regions being special cased here?
| @@ -238,33 +238,8 @@ def most_recent_install_file_path(deployment_group) | |||
| private | |||
| def download_from_s3(deployment_spec, bucket, key, version, etag) | |||
| log(:debug, "Downloading artifact bundle from bucket '#{bucket}' and key '#{key}', version '#{version}', etag '#{etag}'") | |||
| region = ENV['AWS_REGION'] || InstanceMetadata.region | |||
There was a problem hiding this comment.
Why is all of this getting removed?
There was a problem hiding this comment.
The code wasn't removed. It was only moved to the new function s3_options to become more clear.
annamataws
approved these changes
Nov 29, 2018
rohkat-aws
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.