Skip to content

refactor: typehints and imports compatible to Python3.7 #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Nov 8, 2023

Conversation

khubaibalam2000
Copy link
Contributor

Issue #, if available:
This Pull Request resolve the issue mentioned in #627.

Description of changes:
Removed the imports as it is already supported in Python v3.7.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@khubaibalam2000 khubaibalam2000 requested a review from a team as a code owner September 9, 2023 16:37
@ShubhamChaturvedi7
Copy link
Contributor

@khubaibalam2000 Could you use the semantically correct commit name / PR title?

@ShubhamChaturvedi7
Copy link
Contributor

Also, a quick search shows that typehints and imports are scattered all over the place and we should fix them all: https://github.com/search?q=repo%3Aaws%2Faws-dynamodb-encryption-python+%22from+typing+import+Dict%22&type=code

@khubaibalam2000
Copy link
Contributor Author

Sure, in the next commit, I am fixing these imports.

@texastony
Copy link
Contributor

@khubaibalam2000 You recent commits,
probably b4e40e3,
have broken the library.

You should be able to view the logs of the GitHub actions to examine
what tests failed.

You can look at the GitHub Workflow File
in the repo for guidance on running the CI locally.

@khubaibalam2000
Copy link
Contributor Author

khubaibalam2000 commented Sep 24, 2023

@texastony Thank you for your guidance. Now, I am debugging and viewing the CI logs locally and fixing them. Will provide you with unbreakable commit soon.

@texastony texastony changed the title Made typehints and imports compatible to Python3.7 refactor: typehints and imports compatible to Python3.7 Sep 25, 2023
@ShubhamChaturvedi7
Copy link
Contributor

@khubaibalam2000 There are still a lot of CIs failing. Please run them locally so that you can quickly iterate over the issues and fix them. Let us know if you need any help.

@khubaibalam2000
Copy link
Contributor Author

Yes, as per your suggestion, I setup the CI locally and debug the code and found some errors, but now all the error are fixed. In my latest commit 7ac6b60, all CIs are passing. Thank you for yours guidance.

@khubaibalam2000
Copy link
Contributor Author

All the checks are now passing. Is there any work left to do about the issue? or is it done.

Copy link

@lucasmcdonald3 lucasmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@lucasmcdonald3 lucasmcdonald3 merged commit a579b04 into aws:master Nov 8, 2023
@khubaibalam2000
Copy link
Contributor Author

Thank you for your contribution!

Welcome. Good to work with this repo. Going to work in the future issues and PRs too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants