Adding a keyword to represent padding modes not yet implemented #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdonlan
reviewed
Dec 10, 2018
| @@ -35,6 +35,7 @@ enum aws_cryptosdk_rsa_padding_mode { | |||
| AWS_CRYPTOSDK_RSA_PKCS1, | |||
| AWS_CRYPTOSDK_RSA_OAEP_SHA1_MGF1, | |||
| AWS_CRYPTOSDK_RSA_OAEP_SHA256_MGF1, | |||
| AWS_CRYPTOSDK_RSA_NOT_YET_IMPLEMENTED, | |||
There was a problem hiding this comment.
Why is this useful? We can't meaningfully pass it to any method, and we don't know the padding mode to be able to return a "not yet implemented" value from any funciton either.
There was a problem hiding this comment.
I require this to skip few test cases that are not yet implemented here, I can get rid of this once we close Issue#187
There was a problem hiding this comment.
Ok. Please don't add this to the public API just to support your test case. Instead, refactor your test case to have an explicit, separate 'skip test' flag that it can use when it is unable to deserialize the padding mode.
There was a problem hiding this comment.
Alright, closing this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.