Skip to content

chore(deps): upgrade @aws-crypto dependencies to latest major version #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 17, 2023

Conversation

josecorella
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@texastony
Copy link
Contributor

Browser Tests are failing in CodeBuild with:

[Container] 2023/07/15 03:19:11 Running command npm run coverage-browser
...
15 07 2023 03:19:27.443:INFO [karma-server]: Karma v6.4.2 server started at http://localhost:9876/
15 07 2023 03:19:27.445:INFO [launcher]: Launching browsers ChromeHeadlessDisableCors with concurrency unlimited
15 07 2023 03:19:27.449:INFO [launcher]: Starting browser ChromeHeadless
15 07 2023 03:19:27.449:ERROR [launcher]: No binary for ChromeHeadless browser on your platform.
  Please, set "CHROME_BIN" env variable.

Looks like the latest CodeBuild image either does not have ChromeHeadless or does not expose it like the previous version.

@josecorella
Copy link
Contributor Author

josecorella commented Jul 17, 2023

@josecorella josecorella marked this pull request as ready for review July 17, 2023 20:34
@josecorella josecorella requested a review from a team as a code owner July 17, 2023 20:34
texastony
texastony previously approved these changes Jul 17, 2023
Co-authored-by: Tony Knapp <[email protected]>
@texastony texastony merged commit e72954f into master Jul 17, 2023
@texastony texastony deleted the jocorell/prep-mv-release branch July 17, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants