Remove requirement for tell() on decrypt #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
flake8 and pylint checks will still fail on one line in this change being too long. I have some changes staged to address this by way of expanding imports which also makes the code easier to follow, but I think it is better to have those as their own PR for clarity. |
|
Rebased on master to catch |
johnwalker
reviewed
Dec 5, 2018
| @property | ||
| def body_start(self): | ||
| """Log deprecation warning when body_start is accessed.""" | ||
| _LOGGER.warning("StreamDecryptor.body_start is deprecated and will be removed in 1.4.0") |
There was a problem hiding this comment.
Would adding this deprecation message be released through a minor rev or a patch rev?
There was a problem hiding this comment.
Per our versioning statement, the warnings should be added in a Z rev and the removal should happen in a Y rev.
https://github.com/aws/aws-encryption-sdk-python/blob/master/VERSIONING.rst
johnwalker
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #103
Description of changes:
This is the first in a series of changes to implement #103.
This removes the need for the source stream to implement
tell()on the decrypt path.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.