Skip to content

Update PR template #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2019
Merged

Update PR template #171

merged 2 commits into from
Jul 23, 2019

Conversation

johnwalker
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@johnwalker johnwalker requested a review from mattsb42-aws July 15, 2019 18:10
@mattsb42-aws
Copy link
Member

Travis failures are due to known issue #173 and AppVeyor tests are due to known issue #159. Merging.

@mattsb42-aws
Copy link
Member

...correction; I forgot that our branch protection requires Travis to pass...
I think the simple path here is to just get #172 merged, which includes the workaround for #173, and then update this with the new master HEAD.

@johnwalker johnwalker merged commit d3383c6 into aws:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsb42-aws mattsb42-aws mattsb42-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnwalker @mattsb42-aws